ui: Auth Methods List view #9617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
force-pushed
the
ui/feature/auth-methods
branch
from
cda9c88
to
00132bf
Compare
kaxcode
force-pushed
the
ui/feature/auth-methods
branch
from
00132bf
to
91d946e
Compare
johncowen
reviewed
Jan 25, 2021
There was a problem hiding this comment.
I think code-wise this looks great. I noticed a few naming things which would be good to fix up, and while I was doing that I noticed that we might not be mocking the API responses correctly here? The one that is most important is the MaxTokenTTL property, as if that is not in the list responses, then we won't be able to show that value in our listings.
ui/packages/consul-ui/app/components/consul/auth-method/list/index.hbs
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/list/pageobject.js
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/tests/acceptance/dc/acls/auth-methods/sorting.feature
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Outdated
Show resolved
Hide resolved
kaxcode
force-pushed
the
ui/feature/auth-methods
branch
2 times, most recently
from
75873ab
to
18584d2
Compare
kaxcode
force-pushed
the
ui/feature/auth-methods
branch
from
18584d2
to
8bec483
Compare
johncowen
reviewed
Feb 3, 2021
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/type/index.hbs
Outdated
Show resolved
Hide resolved
| oidc: (item, value) => item.Type === value, | ||
| }, | ||
| source: { | ||
| local: (item, value) => item.TokenLocality === value || item.TokenLocality === '', |
There was a problem hiding this comment.
Did we figure out if Consul ever responds with an empty value for TokenLocality?
There was a problem hiding this comment.
yes, it responds with empty ''
There was a problem hiding this comment.
Is that the mocks where you see that empty value or consul itself?
There was a problem hiding this comment.
oh, right. I need to verify this with BE dev.
ui/packages/consul-ui/tests/acceptance/dc/acls/auth-methods/sorting.feature
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/index.scss
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Outdated
Show resolved
Hide resolved
johncowen
reviewed
Feb 4, 2021
ui/packages/consul-ui/app/components/consul/auth-method/index.scss
Outdated
Show resolved
Hide resolved
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Outdated
Show resolved
Hide resolved
johncowen
reviewed
Feb 15, 2021
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Show resolved
Hide resolved
johncowen
reviewed
Feb 15, 2021
ui/packages/consul-ui/app/components/consul/auth-method/search-bar/index.hbs
Show resolved
Hide resolved
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/328626. |
johncowen
added a commit
that referenced
this pull request
Aug 25, 2021
During #9617 we added a list view only for AuthMethods, but not a detail view. We did add the Adapter/Serializer that collected/reshaped data for a detail view. The test for this serializer was skipped here, but I'm not sure why. We then added #9845 which began to use this AuthMethod Serializer, but we didn't go back to finish up the skipped test here either. This PR unskips this test and finishes off the test correctly.
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Aug 25, 2021
During #9617 we added a list view only for AuthMethods, but not a detail view. We did add the Adapter/Serializer that collected/reshaped data for a detail view. The test for this serializer was skipped here, but I'm not sure why. We then added #9845 which began to use this AuthMethod Serializer, but we didn't go back to finish up the skipped test here either. This PR unskips this test and finishes off the test correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/acls/auth-method/:idand/acls/auth-methodsendpoints